Skip to content

Fix warning due to calling getNode() #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Fix warning due to calling getNode() #484

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99b23f3
fix getNode() warning
slorber Apr 29, 2021
f853b37
Merge branch 'master' into fix-getNode-warning
slorber Apr 29, 2021
fcf62b3
better conditions
slorber Apr 29, 2021
7828094
fix import
slorber Apr 29, 2021
e33ad47
lint error
slorber Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/KeyboardAwareHOC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,12 @@ const ScrollIntoViewDefaultOptions: KeyboardAwareHOCOptions = {
// Sometimes the ref you get is a ref to a wrapped view (ex: Animated.ScrollView)
// We need access to the imperative API of a real native ScrollView so we need extraction logic
extractNativeRef: (ref: Object) => {
// getNode() permit to support Animated.ScrollView automatically
// getNode() permit to support Animated.ScrollView automatically, but is deprecated since RN 0.62
// see https://github.com/facebook/react-native/issues/19650
// see https://stackoverflow.com/questions/42051368/scrollto-is-undefined-on-animated-scrollview/48786374
if (ref.getNode) {
// see https://github.com/facebook/react-native/commit/66e72bb4e00aafbcb9f450ed5db261d98f99f82a
const shouldCallGetNode = !Platform.constants || (Platform.constants.reactNativeVersion.major === 0 && Platform.constants.reactNativeVersion.minor < 62)
if (ref.getNode && shouldCallGetNode) {
return ref.getNode()
} else {
return ref
Expand Down