Skip to content

Conversation

AlfieRichardsArm
Copy link
Contributor


name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.


Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution
guidelines
, in particular the section on submitting
a proposal
.

Please use the proposal label.

As for any pull request, please make sure to go through the below
checklist.

Checklist: (mark with X those which apply)

  • If an issue reporting the bug exists, I have mentioned it in the
    PR (do not bother creating the issue if all you want to do is
    fixing the bug yourself).
  • I have added/updated the SPDX-FileCopyrightText lines on top
    of any file I have edited. Format is SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
    (Please update existing copyright lines if applicable. You can
    specify year ranges with hyphen , as in 2017-2019, and use
    commas to separate gaps, as in 2018-2020, 2022).
  • I have updated the Copyright section of the sources of the
    specification I have edited (this will show up in the text
    rendered in the PDF and other output format supported). The
    format is the same described in the previous item.
  • I have run the CI scripts (if applicable, as they might be
    tricky to set up on non-*nix machines). The sequence can be
    found in the contribution
    guidelines
    . Don't
    worry if you cannot run these scripts on your machine, your
    patch will be automatically checked in the Actions of the pull
    request.
  • I have added an item that describes the changes I have
    introduced in this PR in the section Changes for next
    release
    of the section Change Control/Document history
    of the document. Create Changes for next release if it does
    not exist. Notice that changes that are not modifying the
    content and rendering of the specifications (both HTML and PDF)
    do not need to be listed.
  • When modifying content and/or its rendering, I have checked the
    correctness of the result in the PDF output (please refer to the
    instructions on how to build the PDFs
    locally
    ).
  • The variable draftversion is set to true in the YAML header
    of the sources of the specifications I have modified.
  • Please DO NOT add my GitHub profile to the list of contributors
    in the README page of the project.

@AlfieRichardsArm
Copy link
Contributor Author

@labrinea Is this okay with you?

@AlfieRichardsArm AlfieRichardsArm force-pushed the FMV_RESTRICTION branch 2 times, most recently from 6b3d1f2 to f794eed Compare October 3, 2025 12:50
main/acle.md Outdated
* or, as a function annotated with `target_clones(...)` where one
of the versions is `default`.
* Using any C/C++ extensions or attributes that affect function name mangling,
or that clone functions alongside FMV is not supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we state FMV as an acronym, so better use Function Multi Versioning instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a fullstop is missing from the sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing my points being addressed in the latest revision.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, didn't git add 🤦. Updated now!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing another mention of the acronym in a previous bullet point without actually defining it earlier. Perhaps we can add it in a parenthesis or remove the other mention of FMV.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point. I will address that in another PR just for the sake of keeping this clean.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: #417

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far in the document it is being mentioned as Function Multi Versioning. The ABI document https://github.com/ARM-software/abi-aa/blob/main/sysvabi64/sysvabi64.rst#function-multi-versioning mentions it as Function Multi-versioning (FMV). The learning path https://learn.arm.com/learning-paths/cross-platform/function-multiversioning/semantics function multiversioning. I am not sure what is more correct and whether it matters much. Perhaps it's best to keep the docs aligned, or at least all references within a doc the same. I am not opposed to introducing the FMV acronym in ACLE. I'd say use capital letters here (Function Multi Versioning) and we can amend later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes sorry about that, I agree consistency is most important. Changed to use Function Multi Versioning.

@AlfieRichardsArm
Copy link
Contributor Author

@jroelofs @labrinea Do either of you have thoughts with the new wording?

@AlfieRichardsArm AlfieRichardsArm force-pushed the FMV_RESTRICTION branch 2 times, most recently from 69e3480 to 5780236 Compare October 6, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants