Skip to content

Conversation

@mazgch
Copy link
Contributor

@mazgch mazgch commented Oct 13, 2016

Adding u-blox NINA-B1 based board target. The DAPLink HDK is utilizing a KL26z.

@c1728p9
Copy link
Contributor

c1728p9 commented Oct 13, 2016

Thanks for the PR. You'll also need to add an entry to SUPPORTED_CONFIGURATIONS and (optionally) PROJECT_RELEASE_INFO in info.py.


#include "target_config.h"

const char *board_id = "1235";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This board ID is in use

Copy link
Contributor Author

@mazgch mazgch Oct 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just sent an email to Mihail to assign two new board ids. One for EVK-NINA-B1 and one for this other board here.

@mazgch
Copy link
Contributor Author

mazgch commented Oct 17, 2016

Added changes to info.py.

@c1728p9
Copy link
Contributor

c1728p9 commented Oct 18, 2016

Thanks for the changes. I'll trigger testing

@c1728p9
Copy link
Contributor

c1728p9 commented Nov 1, 2016

@mbed-bot: TEST

@screamerbg
Copy link
Contributor

Bump @c1728p9. Is there any blocker on this?

@c1728p9
Copy link
Contributor

c1728p9 commented Nov 18, 2016

I went through the test log and this failure is occuring because the target u-blox-NINA-B1 in not a buildable target. This target needs to be removed and then testing should be able to proceed.

@mazgch can you make this change? After that I'll re-trigger testing.

@mazgch
Copy link
Contributor Author

mazgch commented Nov 21, 2016

Added IO-Config override functionality so that nRESET Pin is moved to a pin available in the smallest package.

@c1728p9 Why did the original pull request fail. It compiles nicely in my environment. Do you have any hint for me what could be wrong. Then I am happy to fix this.

Copy link
Contributor

@c1728p9 c1728p9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment where the code needs to be changed.

test/info.py Outdated
( 0x1114, 'lpc11u35_ssci1114_if', None, 'LPC1114FN28' ),
( 0x1120, 'sam3u2c_mkit_dk_dongle_nrf5x_if', 'sam3u2c_bl', 'Nordic-nRF51-Dongle' ),
( 0x1234, 'lpc11u35_c027_if', None, 'u-blox-C027' ),
( 0x1238, 'kl26z_nina_b1_if', 'kl26z_bl', 'u-blox-NINA-B1' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The u-blox-NINA-B1 isn't available as a target in mbed-os yet. You'll need to replace this with 'None' until this has been added. I would just leave a comment indicating what the target should be when supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok done, the PR for UBLOX_EVA_NINA board is already pending in mbed-os link

@mazgch
Copy link
Contributor Author

mazgch commented Nov 22, 2016

Ok done, the PR for UBLOX_EVA_NINA board is already pending in mbed-os.

@c1728p9
Copy link
Contributor

c1728p9 commented Nov 22, 2016

Thanks for the update. I'll start testing

@c1728p9
Copy link
Contributor

c1728p9 commented Nov 22, 2016

@mbed-bot: TEST

@c1728p9 c1728p9 merged commit cc97a09 into ARMmbed:master Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants