-
Notifications
You must be signed in to change notification settings - Fork 1k
Adding NINA-B1 target board #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR. You'll also need to add an entry to SUPPORTED_CONFIGURATIONS and (optionally) PROJECT_RELEASE_INFO in info.py. |
source/board/nina_b1.c
Outdated
|
|
||
| #include "target_config.h" | ||
|
|
||
| const char *board_id = "1235"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This board ID is in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just sent an email to Mihail to assign two new board ids. One for EVK-NINA-B1 and one for this other board here.
|
Added changes to info.py. |
|
Thanks for the changes. I'll trigger testing |
|
@mbed-bot: TEST |
|
Bump @c1728p9. Is there any blocker on this? |
|
I went through the test log and this failure is occuring because the target u-blox-NINA-B1 in not a buildable target. This target needs to be removed and then testing should be able to proceed. @mazgch can you make this change? After that I'll re-trigger testing. |
|
Added IO-Config override functionality so that nRESET Pin is moved to a pin available in the smallest package. @c1728p9 Why did the original pull request fail. It compiles nicely in my environment. Do you have any hint for me what could be wrong. Then I am happy to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment where the code needs to be changed.
test/info.py
Outdated
| ( 0x1114, 'lpc11u35_ssci1114_if', None, 'LPC1114FN28' ), | ||
| ( 0x1120, 'sam3u2c_mkit_dk_dongle_nrf5x_if', 'sam3u2c_bl', 'Nordic-nRF51-Dongle' ), | ||
| ( 0x1234, 'lpc11u35_c027_if', None, 'u-blox-C027' ), | ||
| ( 0x1238, 'kl26z_nina_b1_if', 'kl26z_bl', 'u-blox-NINA-B1' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The u-blox-NINA-B1 isn't available as a target in mbed-os yet. You'll need to replace this with 'None' until this has been added. I would just leave a comment indicating what the target should be when supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok done, the PR for UBLOX_EVA_NINA board is already pending in mbed-os link
|
Ok done, the PR for UBLOX_EVA_NINA board is already pending in mbed-os. |
|
Thanks for the update. I'll start testing |
|
@mbed-bot: TEST |
Adding u-blox NINA-B1 based board target. The DAPLink HDK is utilizing a KL26z.