Skip to content

Conversation

rajkan01
Copy link
Contributor

  • Updated the htrun readme based on standalone greentea

# Development moved

The development of Htrun has been moved into the [mbed-os-tools](../../src/mbed_os_tools) package. You can continue to use this module for legacy reasons, however all further development should be continued in the new package.
The development of Htrun (mbed-host-tests) has been moved into the [mbed-greentea](https://github.com/ARMmbed/greentea/tree/master) repository under `src/htrun`. You can continue to use this module for legacy reasons, however all further development should be continued in the mbed-greentea repository.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this paragraph here. This repository is already ARMmbed/greentea so there's no "legacy reason" here.

It's probably a leftover notice when development of greentea was moved during early days of Mbed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this paragraph to give some warning to the user as this source moved from a different repo and we will keep this notice until we remove the htrun source from mbed-os-tools

Copy link

@LDong-Arm LDong-Arm Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally a warning is in an old place asking users to look at the new place, rather than in the new place itself like here. I mean, when a user sees this notice, they might think this repo is deprecated, which is the opposite.

I don't mind too much for now as it's a minor detail.

@rajkan01 rajkan01 force-pushed the update_htrun_readme branch from d745982 to 25e0428 Compare June 22, 2021 14:34
@rajkan01 rajkan01 requested a review from LDong-Arm June 22, 2021 14:35
Copy link

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajkan01. As this PR aims to ensure information in the README is generally correct and up-to-date, without any major refactoring or improvements, it looks good to me.

I've just added a few minor comments when I read through the doc again.

@rajkan01 rajkan01 force-pushed the update_htrun_readme branch from 6b59eca to 35bb9ce Compare June 24, 2021 09:29
@rajkan01 rajkan01 requested a review from LDong-Arm June 24, 2021 09:31
Copy link

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater Patater merged commit f923b38 into master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants