Skip to content

Remove gt and cleanup #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2021
Merged

Remove gt and cleanup #321

merged 2 commits into from
Jul 28, 2021

Conversation

@rajkan01
Copy link
Contributor

Fixes #319

  • This PR changes to remove the gt python sources from greentea repo as we decided to use the only htrun for running greentea test using CTest.
  • Updated setup.py to release the only htrun
  • Moved out htrun Readme from src into root dir

@rajkan01 rajkan01 mentioned this pull request Jul 16, 2021
Closed
22 tasks
@rajkan01 rajkan01 force-pushed the remove_gt branch 2 times, most recently from 8465c79 to 38eb164 Compare July 22, 2021 09:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #321 (511e3b6) into master (f727e92) will decrease coverage by 7.80%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   58.84%   51.04%   -7.81%     
==========================================
  Files          65       43      -22     
  Lines        4153     1910    -2243     
==========================================
- Hits         2444      975    -1469     
+ Misses       1709      935     -774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f727e92...511e3b6. Read the comment docs.

@rajkan01 rajkan01 requested a review from rwalton-arm July 22, 2021 10:03
rwalton-arm
rwalton-arm suggested changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@rwalton-arm rwalton-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I've left a couple of comments.

One thing I noticed: we seem to have reduced the overall test coverage on the remaining code by 7.81%. Do you have any ideas for how we could increase it back to the previous level?

@rwalton-arm rwalton-arm linked an issue Jul 23, 2021 that may be closed by this pull request
Make a new pypi package greentea-host for holding host-test stuff #318
Closed
rajkan01 added 2 commits July 26, 2021 02:10
@rajkan01
Remove gt and cleanup
3dc2f9c 
- As decided to use the only htrun for running greentea test using CTest
this PR changes to remove the gt python sources from greentea repo
- Updated setup.py to release the only htrun
- Moved out htrun Readme from src into root dir
@rajkan01
python: Update prettytable version
511e3b6 
Update prettytable requirement to `<3.0,>=2.0` to fulfill latest python
version expectation
@rajkan01 rajkan01 requested a review from rwalton-arm July 26, 2021 09:18
@Patater Patater merged commit 0367a99 into master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rwalton-arm rwalton-arm rwalton-arm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove mbedgt/gt from ARMmbed/greentea Make a new pypi package greentea-host for holding host-test stuff

5 participants

@rajkan01 @codecov-commenter @rwalton-arm @Patater