Skip to content
This repository was archived by the owner on Jul 7, 2021. It is now read-only.

Pin major versions wherever we can. #73

Merged
merged 4 commits into from
Jan 28, 2019
Merged

Pin major versions wherever we can. #73

merged 4 commits into from
Jan 28, 2019

Conversation

jonikula
Copy link
Contributor

Status

READY

Description

Pin major versions of our requirements in our requirements.txt and setup.py files. Related to issue #69.

@jonikula jonikula added this to the v1.1.1 milestone Jan 23, 2019
@jonikula jonikula requested a review from jupe January 23, 2019 06:21
@jonikula
Copy link
Contributor Author

Looks like there's some issue with lxml install. Testing.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 573

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.547%
Totals Coverage Status
Change from base Build 558: 0.0%
Covered Lines: 4994
Relevant Lines: 7079
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 574

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.547%
Totals Coverage Status
Change from base Build 558: 0.0%
Covered Lines: 4994
Relevant Lines: 7079
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 724

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.547%
Totals Coverage Status
Change from base Build 717: 0.0%
Covered Lines: 4994
Relevant Lines: 7079
💛 - Coveralls

@jonikula jonikula merged commit 75cef7a into master Jan 28, 2019
@jonikula jonikula deleted the req_pinning branch January 28, 2019 07:46
@jonikula jonikula modified the milestones: v1.1.1, v1.2.0 Jan 28, 2019
@bridadan bridadan mentioned this pull request Jan 28, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jupe jupe jupe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jonikula @coveralls @jupe