Secure element driver interface test strategy #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just the structure for now, no actual content.
gilles-peskine-arm
added
enhancement
Patater
suggested changes
Sep 4, 2019
Patater
suggested changes
Sep 5, 2019
|
|
||
| * Wherever the specification guarantees parameters that satisfy certain preconditions, check these preconditions whenever practical. | ||
| * If the API function can take parameters that are invalid and must not reach the driver, call the API function with such parameters and verify that the driver method is not called. | ||
| * Check that the expect inputs reach the driver. This may be implicit in a test that checks the outputs if the only realistic way to obtain the correct outputs is to start from the expected inputs (as is often the case for cryptographic material, but not for metadata). |
There was a problem hiding this comment.
I amended the last commit.
|
LGTM other than one nit |
gilles-peskine-arm
force-pushed
the
psa-se_driver-interface_test_strategy
branch
from
5b1d027 to
8b193c1
Compare
Patater
previously approved these changes
Sep 5, 2019
Patater
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a test strategy document describing what I think we should test about the secure element driver interface (the Mbed Crypto code — this is not about how to test drivers).