Callback: nullptr adjustments #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust wording to talk of Callback's being "empty", which is clearer than "null", and avoids thought of `NULL`. Add explicit note about using `nullptr` to reset. Preparation for ARMmbed/mbed-os#12036 - can be merged now as adjustments are valid for existing code.
Tweak phrasing for active voice.
AnotherButler
approved these changes
Dec 18, 2019
0xc0170
approved these changes
Jan 14, 2020
AnotherButler
pushed a commit
that referenced
this pull request
Jan 14, 2020
Apply changes from PR #1184 to v5.15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust wording to talk of Callback's being "empty", which is clearer
than "null", and avoids thought of
NULL. Add explicit note about usingnullptrto reset.Preparation for ARMmbed/mbed-os#12036 - can be
merged now as adjustments are valid for existing code.