Extend bootstrap waiting loops 105->115 #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bootstrap_complete = "Connected. IP =" | ||
| bootstrap_fail = "Connection failed!" | ||
| loops = 105 # Connection can take up a long time (>1020 seconds in case of Wi-SUN). | ||
| loops = 115 # Connection can take up a long time (>1020 seconds in case of Wi-SUN). |
There was a problem hiding this comment.
@mikter is this long enough timeout that you are interested to investigate if this fails?
|
Looks like the third test(3/3) failed. Looks like it didn't test with the new loop count. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1050 seconds appears to be a little too close in Wi-SUN case. Test fails a bit too often. Propose increasing waiting period to 1150.