Fix IAR build failure #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
approved these changes
Feb 18, 2020
kjbracey
approved these changes
Feb 18, 2020
| void print_socket_stats() | ||
| { | ||
| mbed_stats_socket_t stats[MBED_CONF_NSAPI_SOCKET_STATS_MAX_COUNT] = {0}; | ||
| static mbed_stats_socket_t stats[MBED_CONF_NSAPI_SOCKET_STATS_MAX_COUNT]; |
There was a problem hiding this comment.
I believe this is arguably better anyway - should probably avoid putting potentially-large objects on the stack in case of overflow.
Although on the other hand this is just a temporary for the print, so if there was no overflow danger, automatic is good.
If wanting to keep automatic, a better (C++11 or later) syntax to zero-init than = { 0 } is just {} (no =). That is probably simpler for the compiler, and could also avoid the bug.
There was a problem hiding this comment.
What was the assertion failure?
There was a problem hiding this comment.
Cryptic error:
[DEBUG] Return: 3
[DEBUG] Output: Internal error: [Front end]: assertion failed at: "/home/jenkins_ci01/slave_top/workspace/ArmReleaseBuild/core/translator/compiler_core/src/parser/edg/il.c", line 23626
There was a problem hiding this comment.
I also tested mbed_stats_socket_t stats[MBED_CONF_NSAPI_SOCKET_STATS_MAX_COUNT] {}; , errors as well
Set local `stats` array to static to fix issue ARMmbed/mbed-os#12455. It also avoids putting large objects on the stack.
hugueskamba
force-pushed
the
fix_iar_error
branch
from
5823f14 to
61dd3ad
Compare
evedon
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ARMmbed/mbed-os#12455.
Set local
statsarray to static to fix issue. It also avoids putting large objects on the stack.