Add mbed TLS benchmark example #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the mbed TLS benchmark example that runs multiple cryptographic primitives and reports performance. Also, modified the repository's structure so that each example is in a different subdirectory.
|
@sbutcher-arm @yanesca : Note that:
|
| int main(void) { | ||
| output.baud(115200); | ||
|
|
||
| int ret = benchmark(0, NULL); |
There was a problem hiding this comment.
The original examples were run as a tests. I am not sure this is what we would like to have, but I am happy to add that if you think it adds value to the example.
README.md
Outdated
|
|
||
| This application downloads a file from an HTTPS server (developer.mbed.org) and looks for a specific string in that file. | ||
| This repo contains a collection of mbed TLS example applications based on mbed OS and built with mbedCLI. Each subdirectory contains a separate example meant for building as an executable. | ||
|
|
There was a problem hiding this comment.
We may want to avoid abbreviations and write 'repository' instead of 'repo'.
Fix the benchmark code to remove the conditional preprocessor directives for platform.h. This code is not meant to be portable to anything other than mbed OS, so these are not required. Also, update documentation according to feedback.
benchmark/main.cpp
Outdated
| } while( 0 ) | ||
|
|
||
| #if defined(MBEDTLS_ERROR_C) | ||
| #define PRINT_ERROR \ |
There was a problem hiding this comment.
I think we still need true branch here.
|
+1 |
|
Reviewed and approved for merge. |
This was referenced Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the mbed TLS benchmark example that runs multiple cryptographic
primitives and reports performance. Also, modified the repository's
structure so that each example is in a different subdirectory.