Skip to content

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Jul 9, 2021

Requires: ARMmbed/mbed-os#14880

The test application uses the greentea client for synchronization with the host and unity for assertions, and unity in Mbed OS contains references to utest. We have recently split them from one mbed-greentea library into three, so the test application needs to link all of them.

Notes:

  • The communication between device and host does not currently work, because currently the integration of greentea-client + Mbed OS has an I/O issue. Nonetheless, it does not affect this PR because the version of greentea-client is controlled by Mbed OS which we always use the latest version of.
  • Once this gets in, we need to rebase the branch tfm_latest_integration_check to take advantage of the fix too.

@LDong-Arm LDong-Arm requested a review from a team July 9, 2021 09:36
@Patater Patater self-assigned this Jul 9, 2021
@LDong-Arm
Copy link
Contributor Author

From Travis:

9.98s$ pip install -r mbed-os/requirements.txt
0.35s$ python3 test_psa_target.py -t GNUARM -m ${TARGET_NAME} --cli=2 -b
[Test-Target] 10:10:54: "mbedgt" is not installed. Exiting...

But mbed-os/requirements.txt does contain mbed-greentea.

@Patater
Copy link
Contributor

Patater commented Jul 9, 2021

Travis is failing because mbed-os-tools use a newer prettytable with Python 3 than icetea supports. PR ARMmbed/mbed-os#14880 will fix.

@LDong-Arm
Copy link
Contributor Author

Manually started a nightly run that points to this PR.

@Patater
Copy link
Contributor

Patater commented Jul 20, 2021

ARMmbed/mbed-os#14880 has been merged

The test application uses the greentea client for synchronization
with the host and unity for assertions, and unity in Mbed OS contains
references to utest. We have recently split them from one
mbed-greentea library into three, so the test application needs to
link all of them.
@LDong-Arm
Copy link
Contributor Author

Forced pushed to rerun Travis

@Patater
Copy link
Contributor

Patater commented Jul 21, 2021

Travis still appears to be caching Python dependencies.

Processing /home/travis/.cache/pip/wheels/46/60/6c/bb25d05df22906786206e901e9354bb3061061191116768bee/prettytable-0.7.2-py3-none-any.whl

@Patater
Copy link
Contributor

Patater commented Jul 21, 2021

I'll clear the cache on Travis

@Patater
Copy link
Contributor

Patater commented Jul 21, 2021

Cleared cache for this PR. Rerunning Travis...

@Patater
Copy link
Contributor

Patater commented Jul 21, 2021

Boo, still using cached old prettytable for some reason. I'll clear all cache.

@rwalton-arm
Copy link
Contributor

Boo, still using cached old prettytable for some reason. I'll clear all cache.

Is caching pip installed dependencies a good idea? Dependencies (and transitive dependencies) change so frequently we'd always want to start from a clean environment, I'd assume.

@LDong-Arm
Copy link
Contributor Author

LDong-Arm commented Jul 21, 2021

Even though we removed icetea, requirements.txt still has an old prettytable listed (using == instead of >=): https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt#L3 maybe this needs an update?

@Patater
Copy link
Contributor

Patater commented Jul 21, 2021

Even though we removed icetea, requirements.txt still has an old prettytable listed (using == instead of >=): https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt#L3 maybe this needs an update?

Gah, that looks like the issue. Good spot.

@Patater
Copy link
Contributor

Patater commented Jul 21, 2021

Raised ARMmbed/mbed-os#14940

@Patater
Copy link
Contributor

Patater commented Jul 21, 2021

Merged that mbed-os PR, cleared Travis cache for this PR, and re-kicked it off

@Patater Patater merged commit 08e2759 into ARMmbed:master Jul 21, 2021
@LDong-Arm
Copy link
Contributor Author

Thanks @Patater, it's finally resolved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants