-
Notifications
You must be signed in to change notification settings - Fork 69
Add new Cypress secure boards #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e967891
to
5890f60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also ask PE to update the online entries for these product codes which are currently listed as CYPRESS_PLACEHOLDER
. Thanks.
u'1910': u'CY8CKIT_064B0S2_4343W', | ||
u'1911': u'CY8CKIT_064S0S2_4343W', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The identifiers need to be 20 characters or less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morser499 - As Graham highlights, the target name needs to be limited to 20 characters if possible. This is a requirement comes from of our database which is essential to the online compiler and potentially other tools going forward. I know that some other platforms have gotten in that violate this requirement, which we have not communicated very clearly. We apologize for the inconvenience. We just discussed this with our product manager. It may be possible for us to increase this limit in the future. But at this time, if you can shrink the target name by one character (go from 21 to 20 chars) that would be the quickest solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maclobdell for expanding on my brief comment. We intend to ensure that we remove this limitation in future versions of Mbed OS but at present there is an unknown consequence of going beyond this limit. Unfortunately, some names have breached this limit without us noticing, which has led to further confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reduced the length to 20 characters for the new boards.
Unfortunately this makes the names inconsistent with other boards which can lead to confusion. Hopefully this limit can be addressed sometime soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madchutney any other issues with this or can we get it merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge it in but please also ask PE to update the online entries for these product codes which are still listed as CYPRESS_PLACEHOLDER. Thanks.
5890f60
to
1ca211f
Compare
1ca211f
to
c2e3db5
Compare
Description
Add ID mappings for 3 new Cypress boards
Pull request type
Reviewers