Skip to content

Conversation

morser499
Copy link
Contributor

Description

Add ID mappings for 3 new Cypress boards

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Copy link
Contributor

@madchutney madchutney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also ask PE to update the online entries for these product codes which are currently listed as CYPRESS_PLACEHOLDER. Thanks.

Comment on lines 264 to 265
u'1910': u'CY8CKIT_064B0S2_4343W',
u'1911': u'CY8CKIT_064S0S2_4343W',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The identifiers need to be 20 characters or less.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morser499 - As Graham highlights, the target name needs to be limited to 20 characters if possible. This is a requirement comes from of our database which is essential to the online compiler and potentially other tools going forward. I know that some other platforms have gotten in that violate this requirement, which we have not communicated very clearly. We apologize for the inconvenience. We just discussed this with our product manager. It may be possible for us to increase this limit in the future. But at this time, if you can shrink the target name by one character (go from 21 to 20 chars) that would be the quickest solution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maclobdell for expanding on my brief comment. We intend to ensure that we remove this limitation in future versions of Mbed OS but at present there is an unknown consequence of going beyond this limit. Unfortunately, some names have breached this limit without us noticing, which has led to further confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reduced the length to 20 characters for the new boards.

Unfortunately this makes the names inconsistent with other boards which can lead to confusion. Hopefully this limit can be addressed sometime soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madchutney any other issues with this or can we get it merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it in but please also ask PE to update the online entries for these product codes which are still listed as CYPRESS_PLACEHOLDER. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants