Add Nuvoton NU_M2354 platform #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
target NU_M2354_NPSA_NS (ID: 1312) was set up in database. |
|
@mark-edgeworth |
MarceloSalazar
approved these changes
Mar 20, 2020
|
@MarceloSalazar It appears that this board is listed as |
|
It's been corrected. Should be fine now. |
madchutney
approved these changes
Mar 20, 2020
mark-edgeworth
approved these changes
Mar 23, 2020
mark-edgeworth
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Nuvoton NUMAKER_M2354 target board support .
According to M2351 experience, target name (platform name + suffix) cannot exceed 20 chars.
So based on platform name “NUMAKER_M2354”, it will encounter the target name
“NUMAKER_M2354_NPSA_NS” over 20 chars.
Thus, short the platform name as “NU_M2354”.
Pull request type
Reviewers
@Ronny-Liu