Skip to content

Update M252 platform name #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2020
Merged

Update M252 platform name #220

merged 2 commits into from
Mar 23, 2020

Conversation

cyliangtw
Copy link
Contributor

@cyliangtw cyliangtw commented Mar 13, 2020 •
edited
Loading

Description

To update M252 platform name as NUMAKER_IOT_M252, the purpose is to sync with M252 real board.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@Ronny-Liu
@mark-edgeworth
@MarceloSalazar

@MarceloSalazar MarceloSalazar self-requested a review March 20, 2020 11:12
MarceloSalazar
MarceloSalazar approved these changes Mar 20, 2020
View reviewed changes
Copy link

@MarceloSalazar MarceloSalazar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the target ID and name matches with the online database

mark-edgeworth
mark-edgeworth approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IN online databse

@mark-edgeworth mark-edgeworth merged commit 86272fc into ARMmbed:master Mar 23, 2020
@cyliangtw cyliangtw mentioned this pull request Jul 22, 2020
Merged
@ccli8 ccli8 mentioned this pull request Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyliangtw @mark-edgeworth @MarceloSalazar