Inconsistent Licensing Information

[maxgerhardt]

Description

The LICENCE.md file of mbed-os states: https://github.com/ARMmbed/mbed-os/blob/master/LICENSE.md

Folders containing files under different permissive license than Apache 2.0 are listed below. Each folder should contain its own README file with license specified for its files. The original license text is included in those source files.
[..]
features/storage - BSD-style, MIT

However, looking at the actual source code files of features/storage, lots of them are also Apache 2.0 licensed.

mbed-os/features/storage/nvstore/source/nvstore.cpp

Lines 1 to 15 in dc1198b

	/*
	* Copyright (c) 2018 ARM Limited. All rights reserved.
	* SPDX-License-Identifier: Apache-2.0
	* Licensed under the Apache License, Version 2.0 (the License); you may
	* not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an AS IS BASIS, WITHOUT
	* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

Can you look over the licenses that subfolder again and correct the LICENSE.md?

Issue request type

[X] Question
[ ] Enhancement
[ ] Bug

[maxgerhardt]

Also I don't understand why header file https://github.com/ARMmbed/mbed-os/blob/master/features/storage/blockdevice/ExhaustibleBlockDevice.h is MIT-licensed and its source code https://github.com/ARMmbed/mbed-os/blob/master/features/storage/blockdevice/ExhaustibleBlockDevice.cpp is Apache 2.0 licensed. Huh?

[maxgerhardt]

And the LittleFS C++ class is licensed Apache-2.0 whereas the underlying C implementation is in BSD-3-Clause.

[cmonr]

@ARMmbed/mbed-os-storage @geky

[ciarmcom]

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-1133

[0xc0170]

However, looking at the actual source code files of features/storage, lots of them are also Apache 2.0 licensed.

It's stated in the license file as "Folders containing files under different permissive license than Apache 2.0 are listed below". By default, all files should be Apache 2.0.

To clarify: https://github.com/ARMmbed/mbed-os/blob/master/LICENSE.md - lists folders containing non Apache folders. Each of this folder should contain own license file with more details (list of files, license text) - this still needs to be done for many of these folders.

Also I don't understand why header file https://github.com/ARMmbed/mbed-os/blob/master/features/storage/blockdevice/ExhaustibleBlockDevice.h is MIT-licensed and its source code https://github.com/ARMmbed/mbed-os/blob/master/features/storage/blockdevice/ExhaustibleBlockDevice.cpp is Apache 2.0 licensed. Huh?

@yossi2le Please fix

And the LittleFS C++ class is licensed Apache-2.0 whereas the underlying C implementation is in BSD-3-Clause.

C implementation is BSD-3-Clause - code comes from external repository. The C++ object for Mbed OS is under Apache 2.0 - as stated above - this is our default license.

[0xc0170]

@maxgerhardt If you got further questions, let us know.

I'll close this as resolved. Blockdevice file fix is here #10414