TARGET_STM32F412xG contains system_clock.c in MCU level

[boraozgen]

Description of defect

https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/system_clock.c

should be moved to

https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F412xG/TARGET_NUCLEO_F412ZG

as already is with other targets.

System_clock.c defines board level behavior, such as clock initialization with external or internal clock. For example we use a custom board with this chip where we provide our own system_clock.c implementation which suits our board. Therefore this file should reside in board level.

Another solution could be to define the functions in system_clock.c as __weak to let custom board users to override them.

Target(s) affected by this defect ?

STM32F412xG

Toolchain(s) (name and version) displaying this defect ?

Not relevant.

What version of Mbed-os are you using (tag or sha) ?

mbed-os-6.3.0

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

Not relevant.

How is this defect reproduced ?

Not relevant.

[jeromecoutant]

No, it is not an issue.
As long as the file can be common to all targets below TARGET_STM32F412xG, we prefer to avoid duplication

[boraozgen]

System_clock.c defines board level behavior, such as clock initialization with external or internal clock. For example we use a custom board with this chip where we provide our own system_clock.c implementation which suits our board. Therefore this file should reside in board level.

[jeromecoutant]

Do you think something like:

#if HSE_VALUE==8000000
        RCC_OscInitStruct.PLL.PLLM            = 8;
...
#elif HSE_VALUE==XXX
        RCC_OscInitStruct.PLL.PLLM            = X;
...
#else
error("xxx")
#endif

could match your need ?

[boraozgen]

Well I do not exactly know the exact needs of the configuration since we generated the file from STM32CubeMX. I can check which lines make the difference, but I am sure that the system_clock.c from Mbed did not work out of the box.

[jeromecoutant]

Basic goal of trying to make common the maximum of files is maintenance and evolution.

If someone is updating this file to add a good feature or correct an issue,
in ST, we can test it with the NUCLEO board,
but we can't test with all other boards.
If files are common, every targets are improved.

[boraozgen]

In this case could the functions be defined as __weak to let custom board users to override them?

[ciarmcom]

@boraozgen thank you for raising this issue.Please take a look at the following comments:

Could you add some more detail to the description? A good description should be at least 25 words.

NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'.This indicates to us that at least all the fields have been considered.
Please update the issue header with the missing information, the issue will not be mirroredto our internal defect tracking system or investigated until this has been fully resolved.

[ciarmcom]

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/MBOTRIAGE-2834