CMake Samsung: target files have dependency on connectivity #14025
Description
Description of defect
@ARMmbed/team-samsung Please review these files and why are they in
targets/TARGET_Samsung/TARGET_SIDK_S5JS100/CMakeLists.txt - this is where we found these files:
# TODO CMAKE: The files commented below trigger a dependency on other libraries
# they should be moved somewhere in the connectivity directory.
# dcxo_update.cpp
# mbed_main_init.cpp
# modem/modem_io_device.cpp
# modem/modem_link_device_shmem.cpp
# modem/s5js100_mbox_ipc.cpp
# modem/shmem_save.cpp
You can try to add modem but it will request additional files that are not part of mbed-core. There are couple of files that include mbed.h , this should be removed (see mbed-os/targets/TARGET_Samsung/TARGET_SIDK_S5JS100/modem files).
Target(s) affected by this defect ?
SIDK_S5JS100
Toolchain(s) (name and version) displaying this defect ?
All
What version of Mbed-os are you using (tag or sha) ?
mbed-os-99.99.99
What version(s) of tools are you using. List all that apply (E.g. mbed-cli)
Not relevant
How is this defect reproduced ?
Review the files shared above