unmatched bracket in stm32F4 i2c_device.h

[rotu]

Description of defect

i2c_compile.h has an unclosed bracket:

mbed-os/targets/TARGET_STM/TARGET_STM32F4/i2c_device.h

Lines 21 to 23 in 14e5d30

	#ifdef __cplusplus
	extern "C" {
	#endif

This is not a functional problem today since the file is only included from .c files, not .cpp files. It upsets static analysis tools like clang-tidy and will break if you try to include file from a c++ compilation unit.

Target(s) affected by this defect ?

STM32F4x

Toolchain(s) (name and version) displaying this defect ?

N/A

What version of Mbed-os are you using (tag or sha) ?

338e37a

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

Mbed Studio 1.4.1, ARMC6

How is this defect reproduced ?

Code inspection

[rotu]

This same problem exists in STM32F0, STM32F1, STM32F2, and others

[ciarmcom]

@rotu thank you for raising this issue.Please take a look at the following comments:

Could you add some more detail to the description? A good description should be at least 25 words.

NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'. This indicates to us that at least all the fields have been considered.
Please update the issue header with the missing information, the issue will not be mirrored to our internal defect tracking system or investigated until this has been fully resolved.

[ciarmcom]

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-3974

[0xc0170]

@ARMmbed/team-st-mcd Please review

[jeromecoutant]

Good catch!
@rotu do you plan to correct all the missing } you have found ?

[rotu]

I am but I was not planning on adding static analysis to the codebase. This is pretty low-hanging fruit for such a tool.

[rotu]

I couldn't get cppcheck nor clang-check working to check this.

Since I can't satisfy the "Test results" requirement of pull requests, I'm not planning on fixing this.

[rotu]

Maybe if I knew how to build the mbed-stm CMAKE target, I could force it to treat .c files as .cpp, and verify that I got them all that way.

Aha! found the docs at mbed_os/tools/cmake/README.md. Maybe I can do this after all!

Nevermind. Everything does EXCLUDE_FROM_ALL. I think it's worth verifying everything builds as c++ but I just don't know how to build all targets with mbed-os's build system.

[0xc0170]

You can use set_source_files_properties(filename.c PROPERTIES LANGUAGE CXX ) for changed files so they would be compiled with c++ compiler instead.

If it is just i2c for multiple families, change i2c_api.c to be compiled as c++ (few families).

[jeromecoutant]

I made a quick parsing script :-)
See #14686