Skip to content

Fix SPIF speed for MTB_ADV_WISE_1570 and max packet size for BC95 #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Fix SPIF speed for MTB_ADV_WISE_1570 and max packet size for BC95 #10180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd07b6
Cellular: Fix max packet size for BC95 driver
Mar 21, 2019
a6c44f8
SPIF: Fix SPI_FREQ for MTB_ADV_WISE_1570
Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/storage/blockdevice/COMPONENT_SPIF/mbed_lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
"SPI_MOSI": "PA_7",
"SPI_MISO": "PA_6",
"SPI_CLK": "PA_5",
"SPI_CS": "PB_12"
"SPI_CS": "PB_12",
"SPI_FREQ": "20000000"
}
}
}
8 changes: 7 additions & 1 deletion features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularStack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#include "CellularUtil.h"
#include "CellularLog.h"

#define PACKET_SIZE_MAX 1358

using namespace mbed;
using namespace mbed_cellular_util;

Expand Down Expand Up @@ -174,6 +176,10 @@ nsapi_size_or_error_t QUECTEL_BC95_CellularStack::socket_sendto_impl(CellularSoc
{
int sent_len = 0;

if (size > PACKET_SIZE_MAX) {
return NSAPI_ERROR_PARAMETER;
}

char *hexstr = new char[size * 2 + 1];
int hexlen = char_str_to_hex_str((const char *)data, size, hexstr);
// NULL terminated for write_string
Expand Down Expand Up @@ -220,7 +226,7 @@ nsapi_size_or_error_t QUECTEL_BC95_CellularStack::socket_recvfrom_impl(CellularS

_at.cmd_start("AT+NSORF=");
_at.write_int(socket->id);
_at.write_int(size);
_at.write_int(size <= PACKET_SIZE_MAX ? size : PACKET_SIZE_MAX);
_at.cmd_stop();
_at.resp_start();
// receiving socket id
Expand Down