Skip to content

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Mar 26, 2019

Description

Switches astyle command to use grep instead of fgrep. (fgrep === grep -F).

Strings passed into grep with fgrep are treated as plain text, whereas now, we want to match the start of strings.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

fgrep === grep -F
-F treats lines as fixed strings (aka, the '^' isn't expanded)
@cmonr cmonr requested a review from a team March 26, 2019 00:45
@cmonr
Copy link
Contributor Author

cmonr commented Mar 26, 2019

CI started

@ciarmcom
Copy link
Member

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor Author

cmonr commented Mar 26, 2019

Proof that the fix works this time around...
cmonr#43

@cmonr cmonr mentioned this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants