Flagging WEAK method implementation for default construction #10363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
requested review from
a team,
0xc0170,
AnttiKauppila,
AriParkkila and
cmonr
|
@hasnainvirk, thank you for your changes. |
kivaisan
approved these changes
Apr 10, 2019
0xc0170
changed the title
|
Can you fix wording in the commit (I've already fixed the title). |
CellularDevice::get_default_instance() is a weak method and is overriden by either a default construction provided in the code or by application at some stage. This method needs to be flagged otherwise using another driver will be hindered by the default overriding of this driver.
hasnainvirk
force-pushed
the
flagging_default_ctor
branch
from
739704f to
34fc828
Compare
Sorry for the typo. Fixed. |
0xc0170
approved these changes
Apr 10, 2019
|
Ci started |
Test run: FAILEDSummary: 3 of 7 test jobs failed Failed test jobs:
|
|
Restarted jenkins-ci |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CellularDevice::get_default_instance() is a weak method and is overriden
by either a default construction provided in the code or by application
at some stage. This method needs to be flagged otherwise using another
driver will be hindered by the default overriding of this driver.
Pull request type
Reviewers
@AnttiKauppila @AriParkkila @cmonr @0xc0170
Release Notes