Skip to content

Update comments and improve readability for the BusInOut class #10408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2019
Merged

Update comments and improve readability for the BusInOut class #10408

merged 2 commits into from
Apr 18, 2019

Conversation

sg-
Copy link
Contributor

@sg- sg- commented Apr 15, 2019

Description

Improve the doxygen comments for BusInOut

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnotherButler

@AnotherButler AnotherButler requested a review from kegilbert April 15, 2019 20:25
AnotherButler
AnotherButler approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2019

Please review spellcheck errors, there are two:

Errors: 
28: constucted
29: digitial

@AnotherButler
Copy link
Contributor

😲 Shocking.
Great catch, @0xc0170 👍

@mbed-ci
Copy link

mbed-ci commented Apr 16, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 8c69607 into ARMmbed:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kegilbert kegilbert Awaiting requested review from kegilbert

+1 more reviewer

@AnotherButler AnotherButler AnotherButler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.12.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sg- @0xc0170 @AnotherButler @mbed-ci