Cellular: Minor doc update for CellualrSocket object #10453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
reviewed
Apr 23, 2019
Socket ID is usually spitted out by the modem, however there are cases when the modem is actully taken in as an input argument, e.g., in the case of QUECTEL M26 modem. This minor knit clarifies that the CellularSocket::id can be an input argument.
hasnainvirk
force-pushed
the
minor_doc_update
branch
from
e792c19 to
4eaffb4
Compare
|
@AriParkkila @mirelachirica The comment is rephrased. Please review again. |
ciarmcom
requested review from
a team,
AnttiKauppila,
AriParkkila,
blind-owl and
mirelachirica
|
@hasnainvirk, thank you for your changes. |
AriParkkila
approved these changes
Apr 25, 2019
|
ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
adbridge
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Socket ID is usually spitted out by the modem, however there are cases
when the modem is actully taken in as an input argument, e.g., in the
case of QUECTEL M26 modem. This minor knit clarifies that the
CellularSocket::id can be an input argument.
Pull request type
Reviewers
@blind-owl @AriParkkila @mirelachirica @AnttiKauppila
Release Notes