Cellular: Fix PLMN debug trace for IAR #10825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAR does not allow printing from null pointer as parameter for %s. PLMN string can be null depending on user configuration.
AnttiKauppila
approved these changes
Jun 13, 2019
|
@kivaisan, thank you for your changes. |
0xc0170
approved these changes
Jun 13, 2019
|
I can see bot overwrote already one approval, I'll bump the internal issue about this one |
|
Ci started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
jarvte
approved these changes
Jun 14, 2019
|
Build failure does not look related, IAR assembly file returns error, restarting |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
There's fix proposed in #10833, will restart CI after |
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IAR does not allow printing from null pointer as parameter for %s. PLMN string
can be null depending on user configuration.
Pull request type
Reviewers
@jarvte @AnttiKauppila
Release Notes