Skip to content

Check Cellular Properties have been set #10858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

Check Cellular Properties have been set #10858

merged 1 commit into from
Jun 25, 2019

Conversation

LMESTM
Copy link
Contributor

@LMESTM LMESTM commented Jun 18, 2019

Description

When returning a pointer to a position in the array, it's better to check that the ARRAY is valid and has been set before.

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team June 18, 2019 17:00
@ciarmcom
Copy link
Member

@LMESTM, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@LMESTM LMESTM force-pushed the fix_cellular_properties branch from 5cdb173 to 3286472 Compare June 20, 2019 07:24
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 23, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2019

2 failed jobs restarted (internal error)

@0xc0170 0xc0170 merged commit 34eefb4 into ARMmbed:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adbridge adbridge adbridge approved these changes

+1 more reviewer

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.13.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LMESTM @ciarmcom @adbridge @mbed-ci @0xc0170 @AnttiKauppila