Add new features to Toshiba's TMPM3HQ #10873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ganesh-ramachandran, thank you for your changes. |
|
I'll review this one on Monday, sorry for the delay |
0xc0170
requested changes
Jul 2, 2019
|
|
||
| int rtc_isenabled(void) | ||
| { | ||
| return flag; // Return a flag that represents status of RTC peripheral driver |
There was a problem hiding this comment.
same question as in another PR if this is usable after app resets
There was a problem hiding this comment.
@0xc0170, RTC status register is not in Toshiba MCUs. However, verified with RTC initialized status.
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
approved these changes
Jul 5, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new features to Toshiba's TMPM3HQ
Tested with all 3 toolchains and attached test logs:
M3HQ_ARM_TestResults.txt
M3HQ_GCC_ARM_TestResults.txt
M3HQ_IAR_TestResults.txt
Pull request type
Reviewers
Release Notes