Skip to content

FPGA SPI: ASYNC issue #11010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2019
Merged

FPGA SPI: ASYNC issue #11010

merged 1 commit into from
Jul 12, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

Seems that async test part needs some patch:

@LMESTM @c1728p9 @MarceloSalazar @ithinuel

To check with others targets?

Thx

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

c1728p9
c1728p9 approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@c1728p9 c1728p9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mprse

@ciarmcom ciarmcom requested review from a team July 9, 2019 23:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 9, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

mprse
mprse approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch.
I confirm that the test still works on K64F.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019

CI internal issue, will restart once fixed

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts

@evedon evedon merged commit 2d6db33 into ARMmbed:master Jul 12, 2019
@jeromecoutant jeromecoutant deleted the PR_ASYNCSPI branch July 12, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@mprse mprse mprse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.13.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @c1728p9 @mprse @evedon