NVStore.cpp (and KVStore) - run-time failure handling missing #11084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtomczykmobica Please review & fix those Astyle errors! |
|
@mtomczykmobica, thank you for your changes. |
mtomczykmobica
force-pushed
the
IOTSTOR-832
branch
from
ed0bb39 to
6cdb8f0
Compare
|
astyle fixed |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
SeppoTakalo
approved these changes
Jul 23, 2019
SeppoTakalo
added
release-version: 5.14.0-rc1
needs: CI
and removed
needs: review
labels
|
Changed to "functionality change" because if you change ASSERTS() to runtime checks, then it changes the functionality. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Against to using MBED_ASSERT (works only for DEBUG build, not working with release build) implemented valid failure handling for NVStore nad KVStore.
Pull request type
Reviewers
@JanneKiiskila
@SeppoTakalo
Release Notes