Skip to content

Xpresso: qspi_write fix #11168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2019
Merged

Xpresso: qspi_write fix #11168

merged 1 commit into from
Aug 9, 2019

Conversation

maciejbocianski
Copy link
Contributor

Due to the data buffer is loaded in two steps the whole block needs protection from being interrupted to prevent write fails.

Description

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-hal
@mmahadevan108

Release Notes

@maciejbocianski maciejbocianski mentioned this pull request Aug 6, 2019
Merged
@ciarmcom ciarmcom requested review from a team and maclobdell August 6, 2019 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 6, 2019

@maciejbocianski, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

mmahadevan108
mmahadevan108 suggested changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes, this fixes the issues I am seeing.

Please include the below line to avoid warnings
#include "platform/mbed_critical.h"

@maciejbocianski
Xpresso: qspi_write fix
f2599f4 
Due to the data buffer is loaded in two steps the whole block needs protection from being interrupted
@maciejbocianski
Copy link
Contributor Author

fixed

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit fd931a1 into ARMmbed:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

+1 more reviewer

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.13.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maciejbocianski @ciarmcom @0xc0170 @mbed-ci @mmahadevan108