Skip to content

Cellular: Remove old deprecated tests #11615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

Cellular: Remove old deprecated tests #11615

merged 1 commit into from
Oct 14, 2019

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Oct 3, 2019

Description

Cellular tests have been replaced with generic mbed-os netsocket and network interface tests.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@AriParkkila @AnttiKauppila @mirelachirica @kimlep01

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Oct 3, 2019

@kivaisan, thank you for your changes.
@mirelachirica @kimlep01 @AnttiKauppila @AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

AriParkkila
AriParkkila approved these changes Oct 3, 2019
View reviewed changes
TESTS/netsocket/README.md
}
```

Cellular tests require some more configuration, so for cellular purposes, the `mbed_app.json` might look like this:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also refer to CellularInterface.json with a spell, e.g.: mbed test -n tests-netsocket-udp --app-config=tools/test_configs/CellularInterface.json -vv

Copy link
Contributor Author

@kivaisan kivaisan Oct 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netsocket test README.md already has a reference to these example config files:

Please, see mbed-os/tools/test_configs folder for examples for different technologies.

I updated it a bit to mention about different technologies.

Cellular: Remove old deprecated tests
b6ebfee 
Cellular tests have been replaced with generic mbed-os netsocket and network interface tests.
@AnttiKauppila
Copy link

@ARMmbed/mbed-os-maintainers Please proceed with this

@adbridge
Copy link
Contributor

adbridge commented Oct 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@AnttiKauppila
Copy link

@ARMmbed/mbed-os-maintainers This is ready to go in

@0xc0170 0xc0170 merged commit 0e7d892 into ARMmbed:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adbridge adbridge adbridge approved these changes

@kimlep01 kimlep01 Awaiting requested review from kimlep01

@mirelachirica mirelachirica Awaiting requested review from mirelachirica

+2 more reviewers

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.14.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kivaisan @ciarmcom @AnttiKauppila @adbridge @mbed-ci @AriParkkila @0xc0170