Skip to content

Conversation

maciejbocianski
Copy link
Contributor

Due to lack of i2c_free function switching between peripherals cause i2c tests failures on some targets. Limit testing to single peripheral until i2c_free is implemented.

Description

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond

Release Notes

Due to lack of i2c_free function switching between peripherals
cause i2c tests failures on some targets.
For now limit testing to single peripheral.
@ciarmcom ciarmcom requested review from a team and jamesbeyond October 24, 2019 13:00
@ciarmcom
Copy link
Member

@maciejbocianski, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-test @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2019

Due to lack of i2c_free function switching between peripherals cause i2c tests failures on some targets. Limit testing to single peripheral until i2c_free is implemented.

Is this tracked as an issue anywhere?

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejbocianski
Copy link
Contributor Author

Due to lack of i2c_free function switching between peripherals cause i2c tests failures on some targets. Limit testing to single peripheral until i2c_free is implemented.

Is this tracked as an issue anywhere?

I don't think it is.
It was added in new HAL I2C API

void i2c_free(i2c_t *obj);

I would suggest adding i2c_free in Mbed 6.0.
@jamesbeyond @0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 28, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants