Skip to content

Conversation

yarbcy
Copy link
Contributor

@yarbcy yarbcy commented Oct 29, 2019

Description (required)

Provide fix for (arm-issue-11643).
#11643
Cypress GPIO pull mode tests fail on CY8CKIT_062_WIFI_B

Summary of change (What the change is for and why)

When PullNone mode, change from CYHAL_GPIO_DRIVE_STRONG -> CYHAL_GPIO_DRIVE_PULL_NONE. Fron now CYHAL_GPIO_DRIVE_PULL_NONE drives CY_GPIO_DM_STRONG when bidirectional or output, CY_GPIO_DM_HIGHZ - when direction is input.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 29, 2019

Can you fix "Merge from internal branch (arm-issue-11643)" rather then provide more meaningful commit message. For instance "Cypress: fix gpio mode none"

You can add second paragraph to the commit message to describe what you did above about none and strong modes.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix commit msg as requested above

@0xc0170 0xc0170 changed the title Fix for (arm-issue-11643) Cypress: fix GPIO mode NONE Oct 29, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2019

@yarbcy Please let us know once updated

@yarbcy yarbcy force-pushed the pr/dev-arm-issue-11643 branch from 42edceb to 8055aaa Compare October 30, 2019 10:01
@yarbcy yarbcy force-pushed the pr/dev-arm-issue-11643 branch from 8055aaa to 50b0847 Compare October 30, 2019 10:06
@yarbcy
Copy link
Contributor Author

yarbcy commented Oct 30, 2019

@0xc0170 I fixed commit message.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Oct 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2019

The CI run only unittests, will check why and should restart

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2019

Restarted CI

@mbed-ci
Copy link

mbed-ci commented Oct 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2019

CI run entire set, just artifacts are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants