equeue: avoid non-standard bit shifts #11782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shifting negative numbers right is implementation-defined, and shifting positive signed numbers left and exceeding positive range is undefined. Take care to make sure we always shift unsigned values.
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
Oct 31, 2019
|
@ARMmbed/mbed-os-core Please review, I'll run CI meanwhile |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Shifting negative numbers right is implementation-defined, and shifting positive signed numbers left and exceeding positive range is undefined.
Take care to make sure we always shift unsigned values.
Attempt to fix #11778
Pull request type (required)
Test results (required)