Skip to content

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 5, 2019

Reverts #11770

@morser499 @ARMmbed/team-cypress This one should be retested. See #11770 (comment). Was crypto example tested?

cc @Patater @dgreen-arm

@ciarmcom ciarmcom requested review from a team and maclobdell November 5, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Nov 5, 2019

@0xc0170, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@dgreen-arm
Copy link
Contributor

I've been able to get the examples working on the CY8CKIT_062_WIFI_BT board just with reverting the deletion of targets/TARGET_Cypress/TARGET_PSOC6/psoc6cm0p/TARGET_CM0P_SLEEP/psoc6_01_cm0p_sleep.c and targets/TARGET_Cypress/TARGET_PSOC6/psoc6cm0p/TARGET_CM0P_SLEEP/psoc6_02_cm0p_sleep.c

They were under TARGET_CM0P_SLEEP, whereas the new files are under COMPONENT_CM0P_SLEEP. I don't know what difference that would cause though.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 5, 2019

@morser499 I would like to understand the intention with component for these files.

@morser499
Copy link

@morser499 I would like to understand the intention with component for these files.

The CM0P files are not targets themselves, they are a component that can be selected for the CM4 based targets. The change was to better align with this to make it clearer what they did.

I believe the issue @dgreen-arm observed is because the targets.json file got left out of the original merge. By changing them from TARGET_ to COMPONENT_ the targets.json needed to have them added as components, not just labels.

@morser499
Copy link

morser499 commented Nov 5, 2019

Submitted PR-11815 to add the targets.json file updates that should have been part of PR-11770. This is required for the CM0+ code to actually get picked up as part of the build process. With PR-11815, this revert should not be needed.

@0xc0170 0xc0170 closed this Nov 6, 2019
@0xc0170 0xc0170 deleted the revert-11770-pr/cm0-images branch October 5, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants