Skip to content

STM32_EMAC cleanup #12018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2019
Merged

STM32_EMAC cleanup #12018

merged 2 commits into from
Dec 5, 2019

Conversation

@jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Dec 3, 2019

Description

Summary of change

#11648 has been merged in parallel of #11536

This PR follows then #11536 moving the deprecated STM_EMAC directory to the correct one.

Regards

@rohfle

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Release Notes

Summary of changes

Impact of changes

Migration actions required

@ciarmcom ciarmcom requested review from a team December 3, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 3, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-ipcore please review.

michalpasztamobica
michalpasztamobica approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 5, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 5, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 5, 2019
@0xc0170 0xc0170 merged commit e9cb9cb into ARMmbed:master Dec 5, 2019
@jeromecoutant jeromecoutant deleted the PR_OLIMEX_EMAC branch December 10, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @michalpasztamobica