Skip to content

Update HAL file to Toshiba's TMPM4G9 #12026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2019
Merged

Update HAL file to Toshiba's TMPM4G9 #12026

merged 3 commits into from
Dec 6, 2019

Conversation

@deepak-shreshti
Copy link
Contributor

Description

Update HAL file to Toshiba's TMPM4G9

Tested with all 3 toolchains and attached test logs:
M4G9_ARM_TestResults.txt
M4G9_GCC_ARM_TestResults.txt
M4G9_IAR_TestResults.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team December 4, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 4, 2019

@deepak-shreshti, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 4, 2019

@deepak-shreshti I would like to request one change needed for these files - add SPDX identifier (proper license). We identified these files as not having any license headers.

0xc0170
0xc0170 requested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepak-shreshti Once updated, let me know

@deepak-shreshti
Copy link
Contributor Author

@0xc0170
updated files for SPDX identifier license

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019 •
edited
Loading

@deepak-shreshti Thanks ! there are also some others, if they can be fixed, it would be great. Separate pull request.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 5, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019

Please review failures, TMPM4G9 fails with linker errors (see build artifacts shared above).

@0xc0170 0xc0170 added needs: work release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Dec 5, 2019
@deepak-shreshti
Copy link
Contributor Author

Resolved linker issue

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 6, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 6, 2019
@0xc0170 0xc0170 merged commit 8d246d8 into ARMmbed:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deepak-shreshti @ciarmcom @0xc0170 @mbed-ci