Skip to content

Conversation

michalpasztamobica
Copy link
Contributor

Summary of changes

The nsapi_dns tests were cross-class tests anyway, going through nsapi_dns and UDPSocket. Now they also include EthernetInterface and only mock the NetworkStack, which makes them the most cross-class module test we could think of in netsocket module.

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila


@ciarmcom ciarmcom requested review from a team and AnttiKauppila December 4, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 4, 2019

@michalpasztamobica, thank you for your changes.
@AnttiKauppila @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

The nsapi_dns tests were cross-class tests anyway, going through nsapi_dns and UDPSocket. Now they also include EthernetInterface and only mock the NetworkStack, which makes them the most cross-class module test we could think of in netsocket module.
@michalpasztamobica
Copy link
Contributor Author

Force-pushed rebase+conflict resolution.
@AnttiKauppila , could you review, please?

@adbridge
Copy link
Contributor

This still needs a maintainer review but I will put it into CI for now.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 13, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Dec 16, 2019
@0xc0170 0xc0170 merged commit fd4288a into ARMmbed:master Dec 16, 2019
@michalpasztamobica michalpasztamobica deleted the dns_module_test branch December 16, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants