Skip to content

Cellular: Add PPP/IP config flags in CellularInterface.json #12078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2019
Merged

Cellular: Add PPP/IP config flags in CellularInterface.json #12078

merged 1 commit into from
Dec 11, 2019

Conversation

@AriParkkila
Copy link

Summary of changes

Add PPP/IP version flags in CellularInterface.json to match with LWIP IP versions.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team December 11, 2019 08:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 11, 2019
@0xc0170 0xc0170 removed the request for review from a team December 11, 2019 10:34
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 11, 2019
@0xc0170 0xc0170 merged commit 095e883 into ARMmbed:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@kivaisan kivaisan kivaisan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AriParkkila @ciarmcom @0xc0170 @mbed-ci @kivaisan