Skip to content

Coverity fixes #12079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2019
Merged

Coverity fixes #12079

merged 3 commits into from
Dec 12, 2019

Conversation

AnttiKauppila
Copy link

Summary of changes

Some small coverity fixes made in this PR

  • ATHandler had one issue
  • UBlox had 2 issues
  • mbed-client-cli had one issue

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Antti Kauppila added 3 commits December 11, 2019 09:25
Coverity fix for ATHAndler
35c2b60 
Unneeded NULL check removed
Coverity fixes for UBlox
c42426a 
- Unneeded class variables refactored away
- Init function refactored to remove duplicate code
Coverity fix for mbed-client-cli
11b1df0 
- uint64_t cast added to avoid overflow
@AnttiKauppila AnttiKauppila requested a review from a team December 11, 2019 07:59
@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 11, 2019
@0xc0170 0xc0170 requested a review from a team December 11, 2019 13:26
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2019

@ARMmbed/team-ublox Please review

@mudassar-ublox
Copy link
Contributor

Looks good to me.

@AnttiKauppila
Copy link
Author

@0xc0170 What else is needed?

@adbridge adbridge merged commit 8fcfbe1 into ARMmbed:master Dec 12, 2019
@AnttiKauppila AnttiKauppila deleted the coverity_fixes branch December 13, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AnttiKauppila @0xc0170 @mbed-ci @mudassar-ublox @SeppoTakalo @adbridge