Skip to content

Nuvoton: Support usbd #12176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 7, 2020
Merged

Nuvoton: Support usbd #12176

merged 13 commits into from
Jan 7, 2020

Conversation

@cyliangtw
Copy link
Contributor

This PR adds implementations of USB Device on Nuvoton targets:

  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487
  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NU_PFM_M2351_NPSA_NS
  • NUMAKER_IOT_M263A

In usbd \mbed-os\TESTS\usb_device\msd, the heap block device must be 64KB at least, so M453/NANO130/NUC472 with SRAM <= 64KB must skip msd test.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

| target                 | platform_name    | test suite                      | result | elapsed_time (sec) | copy_method |
|------------------------|------------------|---------------------------------|--------|--------------------|-------------|
| NUMAKER_PFM_M453-ARMC6 | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-basic  | OK     | 72.46              | default     |
| NUMAKER_PFM_M453-ARMC6 | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-hid    | OK     | 30.37              | default     |
| NUMAKER_PFM_M453-ARMC6 | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-serial | OK     | 41.12              | default     |
mbedgt: test suite results: 3 OK
| target                   | platform_name    | test suite                      | result | elapsed_time (sec) | copy_method |
|--------------------------|------------------|---------------------------------|--------|--------------------|-------------|
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-basic  | OK     | 70.67              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-hid    | OK     | 31.26              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-serial | OK     | 42.81              | default     |
mbedgt: test suite results: 3 OK

| target               | platform_name    | test suite                      | result | elapsed_time (sec) | copy_method |
|----------------------|------------------|---------------------------------|--------|--------------------|-------------|
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-basic  | OK     | 69.13              | default     |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-hid    | OK     | 30.66              | default     |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-usb_device-serial | OK     | 41.73              | default     |
mbedgt: test suite results: 3 OK

mbedgt: test suite report:
| target                 | platform_name    | test suite                      | result | elapsed_time (sec) | copy_method |
|------------------------|------------------|---------------------------------|--------|--------------------|-------------|
| NUMAKER_IOT_M487-ARMC6 | NUMAKER_IOT_M487 | mbed-os-tests-usb_device-basic  | OK     | 66.26              | default     |
| NUMAKER_IOT_M487-ARMC6 | NUMAKER_IOT_M487 | mbed-os-tests-usb_device-hid    | OK     | 26.26              | default     |
| NUMAKER_IOT_M487-ARMC6 | NUMAKER_IOT_M487 | mbed-os-tests-usb_device-msd    | OK     | 89.79              | default     |
| NUMAKER_IOT_M487-ARMC6 | NUMAKER_IOT_M487 | mbed-os-tests-usb_device-serial | OK     | 50.97              | default     |
mbedgt: test suite results: 4 OK

Attached test log files for details.

Reviewers

m487_usbd_test_arm.log
m453_usbd_test_gcc.log
m453_usbd_test_iar.log
m453_usbd_test_arm.log

@ciarmcom ciarmcom requested review from a team and Ronny-Liu December 31, 2019 12:00
@ciarmcom
Copy link
Member

@cyliangtw, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-core please review.

Ronny-Liu
Ronny-Liu approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@Ronny-Liu Ronny-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bulislaw
bulislaw approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xc0170
0xc0170 requested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPDX identifiers, otherwise LGTM

@mbed-ci
Copy link

mbed-ci commented Jan 3, 2020

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2020

Build failures are related, please review

cyliangtw added 13 commits January 3, 2020 20:40
@cyliangtw
Copy link
Contributor Author

Build failures are related, please review

@0xc0170 , Fixed the build failures.

  • Cortex-M0 code size of usb_device-msd test on GCC_ARM is over NANO130 Flash 128KB limitation, so add commit 2764f48 to skip usb-mass-storage disk test for nano130 target.

  • Add commit 95be7da for definition of CLKSEL0_USBSEL_HIRC48.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Jan 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

jenkins-ci/mbed-os-ci_cloud-client-pytest

We are experiencing some internal errors with client test. After the restart, all fine here.

@0xc0170 0xc0170 merged commit fab9e3b into ARMmbed:master Jan 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

We will create an issue soon. Nightly failed for NUMAKER_M252KG. Failures point to this changeset [Error] USBEndpoints_Nuvoton.cpp@143,39: use of undeclared identifier ‘NUMBER_OF_PHYSICAL_ENDPOINTS’. Please check

@0xc0170 0xc0170 mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@bulislaw bulislaw bulislaw approved these changes

@Ronny-Liu Ronny-Liu Ronny-Liu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cyliangtw @ciarmcom @mbed-ci @0xc0170 @bulislaw @Ronny-Liu