Skip to content

Corrected PPP debug trace flagging #12195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

Corrected PPP debug trace flagging #12195

merged 1 commit into from
Jan 7, 2020

Conversation

mikaleppanen
Copy link

Summary of changes

Some parts of PPP debug traces were enabled also on non-debug builds. Now they are correctly disabled. Corrected also compiler warnings that became visible when trace macros were flagged (if clauses without brackets).

Impact of changes

Migration actions required

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

Corrected PPP debug trace flagging
9e41f1f 
Some parts of PPP debug traces were enabled also on non-debug builds.
Now they are correctly disabled. Corrected also compiler warnings
that became visible when trace macros were flagged (if clauses without
brackets).
@ciarmcom ciarmcom requested review from a team January 7, 2020 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 7, 2020

@mikaleppanen, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

CI started

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Jan 7, 2020
@mbed-ci
Copy link

mbed-ci commented Jan 7, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170 0xc0170 removed the needs: CI label Jan 7, 2020
@0xc0170 0xc0170 merged commit d4c2fd5 into ARMmbed:master Jan 7, 2020
@mikaleppanen mikaleppanen mentioned this pull request Jan 8, 2020
Closed
@mikaleppanen mikaleppanen mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mikaleppanen @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @AriParkkila