Skip to content

ESP8266: Replace UARTSerial references with BufferedSerial #12213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2020
Merged

ESP8266: Replace UARTSerial references with BufferedSerial #12213

merged 1 commit into from
Jan 17, 2020

Conversation

@hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Jan 8, 2020 •
edited
Loading

Summary of changes

BufferedSerial is UARTSerial renamed to convey the original purpose
of the class. It is the recommended buffered I/O serial class.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@VeijoPesonen @SeppoTakalo

@ciarmcom ciarmcom requested review from a team, SeppoTakalo and VeijoPesonen January 8, 2020 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 8, 2020

@hugueskamba, thank you for your changes.
@VeijoPesonen @SeppoTakalo @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

@hugueskamba Please review Travis failures

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

To be merged only after #12207

👍 I've noticed this one just now in other PRs as well. All of them should have "preceding PR label", will fix

@hugueskamba
ESP8266: Replace UARTSerial references with BufferedSerial
efb5127 
`BufferedSerial` is `UARTSerial` renamed to convey the original purpose
of the class. It is the recommended buffered I/O serial class.
@hugueskamba hugueskamba force-pushed the hk-replace-uartserial-esp branch from 8f57f64 to efb5127 Compare January 16, 2020 10:34
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Jan 17, 2020
@0xc0170 0xc0170 merged commit 67cf9f7 into ARMmbed:master Jan 17, 2020
@hugueskamba hugueskamba deleted the hk-replace-uartserial-esp branch June 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evedon evedon evedon approved these changes

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

@VeijoPesonen VeijoPesonen Awaiting requested review from VeijoPesonen

+1 more reviewer

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hugueskamba @ciarmcom @0xc0170 @mbed-ci @evedon @VeijoPesonen @michalpasztamobica