Skip to content

Conversation

@evedon
Copy link
Contributor

@evedon evedon commented Jan 10, 2020

Summary of changes

Fixed baremetal build failures (from nightly CI test).

Impact of changes

Baremetal nightly tests should build successfully.

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team January 10, 2020 14:00
@ciarmcom
Copy link
Member

@evedon, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Fixed baremetal build failures Fix baremetal build failures Jan 10, 2020
@0xc0170 0xc0170 removed the request for review from a team January 10, 2020 14:11
@mbed-ci
Copy link

mbed-ci commented Jan 10, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

I set this to 6.0.0 alpha1 to get tests passing for baremetal. cc @adbridge

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Jan 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

As we havent merged anything since Friday (creation of this PR), my assumption is as stated above - baremetal build will pass tonight.

@adbridge adbridge merged commit c366bb4 into ARMmbed:master Jan 13, 2020
@evedon evedon deleted the ed-baremetal-build-failures branch February 25, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants