Skip to content

EFM32: add UART and LEUART for EFM32GG11 #12280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2020
Merged

EFM32: add UART and LEUART for EFM32GG11 #12280

merged 1 commit into from
Jan 21, 2020

Conversation

@amq
Copy link
Contributor

@amq amq commented Jan 18, 2020

Summary of changes

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@stevew817

@amq
EFM32: add UART and LEUART for EFM32GG11
860ccde 
- adds the missing PinMap definitions for UART0, UART1, LEUART0 and LEUART1
- corrects a misplaced `#endif` for `#if DEVICE_SPI` which included `UART_TX`
- all according to https://www.silabs.com/documents/public/data-sheets/efm32gg11-datasheet.pdf
@ciarmcom ciarmcom requested review from a team and stevew817 January 18, 2020 14:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 18, 2020

@amq, thank you for your changes.
@stevew817 @ARMmbed/mbed-os-maintainers please review.

stevew817
stevew817 approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@stevew817 stevew817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @amq !

@adbridge
Copy link
Contributor

adbridge commented Jan 20, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 20, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit b7be277 into ARMmbed:master Jan 21, 2020
@adbridge adbridge added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed ready for merge labels Jan 21, 2020
@mergify
Copy link

mergify bot commented Jan 21, 2020

This PR does not contain release version label after merging.

@amq
Copy link
Contributor Author

amq commented Feb 3, 2020

Would be great if this could be also included in 5.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@stevew817 stevew817 stevew817 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amq @ciarmcom @adbridge @mbed-ci @0xc0170 @stevew817