Skip to content

Fix for issue #12268 (SerialBase.cpp: fix initialization list) #12282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Fix for issue #12268 (SerialBase.cpp: fix initialization list) #12282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions drivers/source/SerialBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
namespace mbed {

SerialBase::SerialBase(PinName tx, PinName rx, int baud) :
_init_func(&SerialBase::_init),
#if DEVICE_SERIAL_ASYNCH
_thunk_irq(this),
#endif
_baud(baud),
_tx_pin(tx),
_rx_pin(rx),
_init_func(&SerialBase::_init)
_rx_pin(rx)
{
// No lock needed in the constructor

Expand All @@ -42,6 +42,7 @@ SerialBase::SerialBase(PinName tx, PinName rx, int baud) :
}

SerialBase::SerialBase(const serial_pinmap_t &static_pinmap, int baud) :
_init_func(&SerialBase::_init_direct),
#if DEVICE_SERIAL_ASYNCH
_thunk_irq(this), _tx_usage(DMA_USAGE_NEVER),
_rx_usage(DMA_USAGE_NEVER), _tx_callback(NULL),
Expand All @@ -52,8 +53,7 @@ SerialBase::SerialBase(const serial_pinmap_t &static_pinmap, int baud) :
_baud(baud),
_tx_pin(static_pinmap.tx_pin),
_rx_pin(static_pinmap.rx_pin),
_static_pinmap(&static_pinmap),
_init_func(&SerialBase::_init_direct)
_static_pinmap(&static_pinmap)
{
// No lock needed in the constructor

Expand Down