Skip to content

Conversation

@adbridge
Copy link
Contributor

Summary of changes

Updated the remove conditions with multiple labels to make them arrays of strings. In the current format the first label got removed but the 2nd label got added instead. This is obviously not as intended.

Impact of changes

Being listed individually one below the other did not work. According to the documentation it should be configured as an array. This should lead to both labels (if present) being removed.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Updated the remove conditions with multiple labels to make them arrays of strings
@adbridge adbridge requested a review from bulislaw January 21, 2020 12:35
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should convert all the usage of both add and remove to this style to limit the future errors. Eg. someone just adds: one - "needs rather than converts it to a array.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for testing.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge adbridge added needs: CI release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 labels Jan 21, 2020
@adbridge
Copy link
Contributor Author

Ci started

@adbridge adbridge merged commit 43a8c90 into master Jan 21, 2020
@0xc0170 0xc0170 deleted the feature-mergify branch July 1, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants