Skip to content

Ble driver set random static address #12321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2020
Merged

Ble driver set random static address #12321

merged 3 commits into from
Jan 30, 2020

Conversation

pan-
Copy link
Member

@pan- pan- commented Jan 28, 2020 •
edited
Loading

Summary of changes

This PR adds the function set_random_address to the HCIDriver class. It allows drivers writer to set the Random Static Address of the controller without using the deprecated API Gap:: setAddress .

This PR supersede #12235 .

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Jan 28, 2020
@mergify
Copy link

mergify bot commented Jan 28, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@pan- pan- requested review from LDong-Arm and hugueskamba January 28, 2020 13:26
@pan- pan- force-pushed the ble-driver-set-random-static-address branch from d7c6ffb to 8282f89 Compare January 28, 2020 13:31
@pan- pan- force-pushed the ble-driver-set-random-static-address branch from 8282f89 to 1970761 Compare January 28, 2020 13:35
LDong-Arm
LDong-Arm approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have we tested it on an actual target, or is the CI able to cover this?

@hugueskamba hugueskamba mentioned this pull request Jan 29, 2020
Merged
@mergify mergify bot added needs: CI and removed needs: work labels Jan 29, 2020
@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@kjbracey kjbracey merged commit ae0704e into ARMmbed:master Jan 30, 2020
@mergify
Copy link

mergify bot commented Jan 30, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 mentioned this pull request Feb 4, 2020
Merged
@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

I've fixed the version: Set to 6.0.0-alpha-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugueskamba hugueskamba Awaiting requested review from hugueskamba

2 more reviewers

@kjbracey kjbracey kjbracey approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pan- @kjbracey @mbed-ci @0xc0170 @LDong-Arm