Skip to content

Conversation

@VeijoPesonen
Copy link
Contributor

Summary of changes

Fixes following compiler warnings:

[Warning] USBMSD.h@266,18: 'USBMSD::_bd' will be initialized after [-Wreorder]
[Warning] USBMSD.h@234,14:   'uint32_t USBMSD::_addr' [-Wreorder]
[Warning] USBMSD.cpp@68,1:   when initialized here [-Wreorder]
[Warning] USBMSD.h@266,18: 'USBMSD::_bd' will be initialized after [-Wreorder]
[Warning] USBMSD.h@234,14:   'uint32_t USBMSD::_addr' [-Wreorder]
[Warning] USBMSD.cpp@81,1:   when initialized here [-Wreorder]
[Warning] NFCEEPROM.h@153,15: 'mbed::nfc::NFCEEPROM::_operation_result' will be initialized after [-Wreorder]
[Warning] NFCEEPROM.h@150,17:   'ac_buffer_t mbed::nfc::NFCEEPROM::_ndef_buffer_reader' [-Wreorder]
[Warning] NFCEEPROM.cpp@23,1:   when initialized here [-Wreorder]
[Warning] mbed_compat.c@81,13: unused variable 'pin' [-Wunused-variable]

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@kjbracey-arm


@VeijoPesonen VeijoPesonen changed the title Fix compiler warnings USBMSD; NFCEEPROM; mbed_compat: Fix compiler warnings Jan 31, 2020
@ciarmcom ciarmcom requested review from a team and kjbracey January 31, 2020 10:00
@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@kjbracey-arm @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: review labels Feb 3, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 3, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 3, 2020
@0xc0170 0xc0170 merged commit 62cc4ec into ARMmbed:master Feb 3, 2020
@mergify mergify bot removed the ready for merge label Feb 3, 2020
@VeijoPesonen VeijoPesonen deleted the fix_compiler_warnings branch February 12, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants