Skip to content

Conversation

@evedon
Copy link
Contributor

@evedon evedon commented Feb 6, 2020

Summary of changes

If mbed::internal::do_timed_sleep_relative_or_forever(millisec) is called with millisec set to zero, then wake_predicate should be checked for NULL before dereferencing.

Impact of changes

Fixes #12285

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team February 6, 2020 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 6, 2020

@evedon, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 10, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 10, 2020
@0xc0170 0xc0170 merged commit 6777288 into ARMmbed:master Feb 10, 2020
@mergify mergify bot removed the ready for merge label Feb 10, 2020
@evedon evedon deleted the fix-thread_sleep_for-zero branch February 25, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HardFault when call thread_sleep_for function with 0 in bare-metal profile

6 participants